Skip to content

Fix thread resume merge dropping repeated user messages#148

Merged
Dimillian merged 1 commit intoDimillian:mainfrom
shaw-baobao:fix/thread-items-dedup
Jan 20, 2026
Merged

Fix thread resume merge dropping repeated user messages#148
Dimillian merged 1 commit intoDimillian:mainfrom
shaw-baobao:fix/thread-items-dedup

Conversation

@shaw-baobao
Copy link
Contributor

Summary

  • avoid counting remote items that already exist locally when deduping optimistic messages
  • add a regression test for repeated user messages with identical text

Problem

When switching threads, thread/resume merges remote items with local optimistic messages. If a user sends the same text twice, the merge can drop the later message because the remote list already contains the earlier one. This makes a previously sent user message disappear after a few tab switches.

Testing

  • npm run lint
  • npm run test
  • npm run typecheck

@Dimillian
Copy link
Owner

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian merged commit e3242ef into Dimillian:main Jan 20, 2026
5 checks passed
gersmann pushed a commit to gersmann/codex-monitor-web that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants